Skip to content

Add then and catch methods to Promise class #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add then and catch methods to Promise class #1668

wants to merge 8 commits into from

Conversation

miguelmarcondesf
Copy link

Issue: 1667

@miguelmarcondesf miguelmarcondesf marked this pull request as ready for review June 14, 2025 20:28
legendecas
legendecas reviewed Jun 17, 2025
View reviewed changes
legendecas
legendecas reviewed Jun 17, 2025
View reviewed changes
legendecas
legendecas reviewed Jun 19, 2025
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.84615% with 18 lines in your changes missing coverage. Please review.

Project coverage is 65.58%. Comparing base (a6213bb) to head (7e3a036).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
napi-inl.h 53.84% 3 Missing and 15 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1668      +/-   ##
==========================================
- Coverage   65.79%   65.58%   -0.22%     
==========================================
  Files           3        3              
  Lines        2146     2185      +39     
  Branches      715      730      +15     
==========================================
+ Hits         1412     1433      +21     
- Misses        162      165       +3     
- Partials      572      587      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas
Copy link
Member

The CI failures are caused by missing of the definition of Promise::Promise().

@miguelmarcondesf
Copy link
Author

The CI failures are caused by missing of the definition of Promise::Promise().

Thank you, just fixed that!

@mhdawson mhdawson moved this from Need Triage to Has PR in Node-API Team Project Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Node-API Team Project
Status: Has PR
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelmarcondesf @codecov-commenter @legendecas